enable pam-plugin-faillock when it's installed with custom settings#724
Merged
chaitu236 merged 1 commit intoni:nilrt/master/nextfrom Sep 4, 2024
Merged
enable pam-plugin-faillock when it's installed with custom settings#724chaitu236 merged 1 commit intoni:nilrt/master/nextfrom
chaitu236 merged 1 commit intoni:nilrt/master/nextfrom
Conversation
amstewart
requested changes
Aug 28, 2024
Contributor
amstewart
left a comment
There was a problem hiding this comment.
NILRT, the NILRT meta layers, and OE repos more generally use commits as the unit of change. Remember to prefix your commit summary with the recipe name you're changing, eg. libpam: enable pam-plugin-faillock on install. And put your justifications and change descriptions in the commit summary.
8eb9657 to
a57268f
Compare
amstewart
requested changes
Sep 3, 2024
Contributor
amstewart
left a comment
There was a problem hiding this comment.
Looks good pending this one change.
…settings - update the pam-plugin-faillock package so that the plugin gets enabled when it's installed - modify some faillock configuration settings - prevent pam-plugin-faillock from being installed when ni-auth is installed This change simplifies Secured, Network-Attached Controller (SNAC) configuration. faillock is required to be enabled on a SNAC. The faillock settings were chosen to comply with SNAC requirements. The conflict with ni-auth was added because from testing it appears that the faillock plugin is incompatible with the ni-auth plugin. Signed-off-by: Alex Hearn <alex.hearn@ni.com>
a57268f to
0532a24
Compare
amstewart
approved these changes
Sep 4, 2024
chaitu236
approved these changes
Sep 4, 2024
1 task
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
ni-authis installedJustification
This change simplifies Secured, Network-Attached Controller (SNAC) configuration, AB#2816939. faillock is required to be enabled on a SNAC. The faillock settings were chosen to comply with SNAC requirements. The conflict with
ni-authwas added because from testing it appears that the faillock plugin is incompatible with the ni-auth plugin.Testing
I tested that opkg returns a clear error message when installing
pam-plugin-faillockdescribing the conflict ifni-authis installed. I confirmed thatlibpam-runtimecontains the customized/etc/security/faillock.conf. After removingni-auth, I installedpam-plugin-faillockand confirmed that the configuration files changed as I expected.I confirmed that
common-authwas reverted after removingpam-plugin-faillock.bitbake packagefeed-ni-core)Procedure
@ni/rtos @amstewart